-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle inspector partial tree update on changed properties #44982
Handle inspector partial tree update on changed properties #44982
Conversation
I was thinking it might be cleaner to revert #44326, and have its changes done again in this PR together with multiline strings. So this would no longer be a regression fix PR but a bugfix and enhancement of the inspector. Then there's also only this PR to cherry-pick for 3.2, with no temporary regression. |
Done with 6583ac3. You can amend this PR to include the changes from #44326 now that you've made them safe, and this PR would now fix #43238 again. |
Adds a cache to the inspector in order to update only modified properties when the property list changes and keep the previous controls whenever possible. This allows calls to property_list_changed_notify to trigger inspector updates without resetting all properties. Fixes godotengine#43238 (re-applies godotengine#44326, reverted because of regression godotengine#44854) Also fixes change signal emission for multiline string properties (same as godotengine#44326 but for multiline strings).
12864e4
to
67eec95
Compare
Given I refactored how inspector refreshes, including checking a polling approach, does this still make sense any more? |
@reduz You're right, it probably doesn't make sense for master anymore. Once issues are confirmed to be fixed on master I'll make a new PR specifically for 3.4 since it can still be useful for 3.x users. |
Closing this as it doesn't apply to master anymore, and might cause undesired side effects on 3.x. |
Adds a cache to the inspector in order to update only modified properties when the property list changes and keep the previous controls whenever possible.
This allows calls to
property_list_changed_notify
to trigger inspector updates without resetting all properties.Fixes #44854 (regression from #44326)Fixes #43238 (re-applies #44326, reverted because of regression #44854)
Also fixes change signal emission for multiline string properties (same as #44326 but for multiline strings).
Note: The case with multiline string property when editing the string in the big popup window will require further changes. It currently closes and re-opens the popup when the inspector is updated (before this PR it was just closing it).