Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.2] Prevent signal disconnection attempts on invalid references #45150

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

YuriSizov
Copy link
Contributor

Same as #45149, but for 3.2. Fixes the error described in #45072, and hopefully also fixes the crash in the editor. If someone with a Linux system can validate that there is a crash and this fixes it, here or using #45149, I would appreciate it.

@YuriSizov YuriSizov added this to the 3.2 milestone Jan 13, 2021
@YuriSizov YuriSizov changed the title Prevent signal disconnection attempts on invalid references [3.2] Prevent signal disconnection attempts on invalid references Jan 13, 2021
@ghost
Copy link

ghost commented Jan 13, 2021

This does fixed the crash for me

@YuriSizov YuriSizov force-pushed the ge-disconnect-crash-3.2 branch from a5702fa to 6b13c84 Compare January 14, 2021 12:21
@akien-mga akien-mga merged commit 258f41c into godotengine:3.2 Jan 15, 2021
@akien-mga
Copy link
Member

Thanks!

@YuriSizov YuriSizov deleted the ge-disconnect-crash-3.2 branch January 15, 2021 15:10
@akien-mga akien-mga modified the milestones: 3.2, 3.3 Apr 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants