Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise SIGKILL instead of CRASH_NOW in child process when fork fails #45157

Merged
merged 1 commit into from
Jan 13, 2021
Merged

Raise SIGKILL instead of CRASH_NOW in child process when fork fails #45157

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions drivers/unix/os_unix.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,7 +308,8 @@ Error OS_Unix::execute(const String &p_path, const List<String> &p_arguments, St

execvp(p_path.utf8().get_data(), &args[0]);
// The execvp() function only returns if an error occurs.
CRASH_NOW_MSG("Could not create child process: " + p_path);
ERR_PRINT("Could not create child process: " + p_path);
raise(SIGKILL);
}

int status;
Expand Down Expand Up @@ -344,7 +345,8 @@ Error OS_Unix::create_process(const String &p_path, const List<String> &p_argume

execvp(p_path.utf8().get_data(), &args[0]);
// The execvp() function only returns if an error occurs.
CRASH_NOW_MSG("Could not create child process: " + p_path);
ERR_PRINT("Could not create child process: " + p_path);
raise(SIGKILL);
}

if (r_child_id) {
Expand Down