Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PathFollow2D unit test #46277

Merged
merged 1 commit into from
Feb 21, 2021
Merged

PathFollow2D unit test #46277

merged 1 commit into from
Feb 21, 2021

Conversation

angad-k
Copy link
Contributor

@angad-k angad-k commented Feb 21, 2021 •
edited
Loading

part of #43440
Adds a unit test for PathFollow2D node.
Tests the following :

  • Sampling with unit offset
  • Sampling with offset
  • Behavior on removal of point from curve
  • Behavior on setting up an h_offset and a v_offset
  • Behavior when unit offset is below 0 and above 1
  • Behavior when offset is below 0 and above the max value

Haven't run the tests yet. Will squash the commits when I run the tests and all the checks pass.

@angad-k angad-k requested a review from a team as a code owner February 21, 2021 10:50
@angad-k angad-k force-pushed the PathFollow2D-unit-test branch from 8e54286 to de330e1 Compare February 21, 2021 10:54
@Chaosus Chaosus added this to the 4.0 milestone Feb 21, 2021
@angad-k angad-k force-pushed the PathFollow2D-unit-test branch from de330e1 to d837fba Compare February 21, 2021 11:02
@angad-k angad-k changed the title PathFollow2D unit test [WIP] PathFollow2D unit test Feb 21, 2021
Xrayez
Xrayez reviewed Feb 21, 2021
View reviewed changes
tests/test_path_follow_2d.h Outdated Show resolved Hide resolved
Xrayez
Xrayez approved these changes Feb 21, 2021
View reviewed changes
Copy link
Contributor

@Xrayez Xrayez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't used those nodes extensively, but tests looks good to me!

Need to squash commits.

@angad-k angad-k force-pushed the PathFollow2D-unit-test branch from 7715ec3 to eecfe4c Compare February 21, 2021 14:18
@angad-k
Copy link
Contributor Author

angad-k commented Feb 21, 2021 •
edited
Loading

Squashed the commits.

@akien-mga akien-mga merged commit c97437a into godotengine:master Feb 21, 2021
@akien-mga
Copy link
Member

Thanks!

@Calinou Calinou mentioned this pull request Mar 24, 2021
Open
99 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xrayez Xrayez Xrayez approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@angad-k @akien-mga @Xrayez @Chaosus