Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on importing empty .fbx file #47717

Merged
merged 1 commit into from
Apr 8, 2021

Conversation

lyuma
Copy link
Contributor

@lyuma lyuma commented Apr 8, 2021

Fixes this crash when an empty .fbx file is placed in the project.
CC @RevoluPowered

CrashHandlerException: Program crashed
Dumping the backtrace. Please include this when reporting the bug on https://github.com/godotengine/godot/issues
[0] EditorSceneImporterFBX::import_scene (S:\repo\godot-pr-pr\modules\fbx\editor_scene_importer_fbx.cpp:111)
[1] ResourceImporterScene::import (S:\repo\godot-pr-pr\editor\import\resource_importer_scene.cpp:1366)
[2] EditorFileSystem::_reimport_file (S:\repo\godot-pr-pr\editor\editor_file_system.cpp:1779)
[3] EditorFileSystem::reimport_files (S:\repo\godot-pr-pr\editor\editor_file_system.cpp:1976)
[4] EditorFileSystem::_update_scan_actions (S:\repo\godot-pr-pr\editor\editor_file_system.cpp:582)
[5] EditorFileSystem::_notification (S:\repo\godot-pr-pr\editor\editor_file_system.cpp:1124)
[6] EditorFileSystem::_notificationv (S:\repo\godot-pr-pr\editor\editor_file_system.h:108)
[7] Object::notification (S:\repo\godot-pr-pr\core\object\object.cpp:795)
[8] SceneTree::_notify_group_pause (S:\repo\godot-pr-pr\scene\main\scene_tree.cpp:811)
[9] SceneTree::process (S:\repo\godot-pr-pr\scene\main\scene_tree.cpp:443)
[10] Main::iteration (S:\repo\godot-pr-pr\main\main.cpp:2495)
[11] OS_Windows::run (S:\repo\godot-pr-pr\platform\windows\os_windows.cpp:622)
[12] widechar_main (S:\repo\godot-pr-pr\platform\windows\godot_windows.cpp:163)
[13] _main (S:\repo\godot-pr-pr\platform\windows\godot_windows.cpp:185)
[14] main (S:\repo\godot-pr-pr\platform\windows\godot_windows.cpp:199)
[15] __scrt_common_main_seh (D:\agent\_work\9\s\src\vctools\crt\vcstartup\src\startup\exe_common.inl:288)
[16] BaseThreadInitThunk
-- END OF BACKTRACE --

@lyuma lyuma force-pushed the fbx_empty_crash branch from 6f4d6b2 to 7d8e981 Compare April 8, 2021 09:52
@akien-mga akien-mga merged commit fe6f226 into godotengine:master Apr 8, 2021
@akien-mga
Copy link
Member

Thanks!

@lyuma lyuma deleted the fbx_empty_crash branch May 19, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants