Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a unit test suite for GDScript #48657

Merged
merged 1 commit into from
May 19, 2021

Conversation

Calinou
Copy link
Member

@Calinou Calinou commented May 11, 2021

This tests run-time script loading and is a complement to the existing integration tests.

@Calinou Calinou requested a review from a team as a code owner May 11, 2021 22:22
@Calinou Calinou added this to the 4.0 milestone May 11, 2021
tests/test_gdscript.h Outdated Show resolved Hide resolved
@akien-mga
Copy link
Member

Shouldn't this go in modules/gdscript/tests/ together with other GDScript tests? And then might need a more explicit name as test_gdscript.h already exists.

@Xrayez
Copy link
Contributor

Xrayez commented May 12, 2021

Shouldn't this go in modules/gdscript/tests/ together with other GDScript tests? And then might need a more explicit name as test_gdscript.h already exists.

Yes, but I'm not sure if this will work, but should likely work... Yet maybe Calinou has other motivations for doing so. But yeah, I'd prefer to have all GDScript related tests to be under modules/gdscript/tests/.

@Calinou Calinou force-pushed the test-add-gdscript branch from da79304 to e2eabce Compare May 12, 2021 14:20
@Calinou Calinou requested a review from a team as a code owner May 12, 2021 14:20
@Calinou
Copy link
Member Author

Calinou commented May 12, 2021

Shouldn't this go in modules/gdscript/tests/ together with other GDScript tests? And then might need a more explicit name as test_gdscript.h already exists.

Done. I ended up just moving the test case into the existing GDScript test suite. The current test suite file is pretty short, so that should be fine.

This tests run-time script loading.
@Calinou Calinou force-pushed the test-add-gdscript branch from e2eabce to 6c528e4 Compare May 12, 2021 14:21
@akien-mga akien-mga merged commit 169268a into godotengine:master May 19, 2021
@akien-mga
Copy link
Member

Thanks!

@vnen
Copy link
Member

vnen commented May 20, 2021

Hm, this is actually crashing for me because the language has not been initialized.

EDIT: It crashes when its running on its own. If running the other GDScript suite it doesn't crash since the other tests initializes the language.

@Calinou Calinou deleted the test-add-gdscript branch August 3, 2021 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants