Add a test suite for Translation

[Calinou]

See #43440.

[akien-mga]

Thanks!

[akien-mga]

So this passed CI in the PR, but not once merged? We seem to have a bug in our unit testing.

 D:\a\godot\godot\tests\test_translation.h(42):
TEST CASE:  [Translation] Messages

D:\a\godot\godot\tests\test_translation.h(63): ERROR: CHECK( messages[0] == "Hello2" ) is NOT correct!
  values: CHECK( @"Hello3" == Hello2 )

D:\a\godot\godot\tests\test_translation.h(64): ERROR: CHECK( messages[1] == "Hello3" ) is NOT correct!
  values: CHECK( @"Hello2" == Hello3 )

[akien-mga]

I could reproduce the issue once locally, but not on subsequent builds. I suspect that SCons doesn't properly pick up new .h files so we get some invalid state somehow.

[akien-mga]

Yeah re-running the CI solved it... we'll have to figure this one out eventually.

[kleonc]

@akien-mga I think the issue is that this part of the test:

godot/tests/test_translation.h

Lines 57 to 64 in 2be9b5d

	translation->add_message("Hello2", "Bonjour2");
	translation->add_message("Hello3", "Bonjour3");
	messages.clear();
	translation->get_message_list(&messages);
	CHECK(translation->get_message_count() == 2);
	CHECK(messages.size() == 2);
	CHECK(messages[0] == "Hello2");
	CHECK(messages[1] == "Hello3");

assumes that Translation preserves insertion order of the messages (and that get_message_list() returns messages in the same order) but it's not the case since Map is used internally as a storage:

godot/core/string/translation.h

Line 42 in 2be9b5d

Map<StringName, StringName> translation_map;

[akien-mga]

Good catch! I guess the test should be changed to use find() or similar?

[kleonc]

Yeah, size check and messages.has(...) for each entry should be sufficient.