-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple address resolution in DNS requests #49026
Conversation
There is a guide for pr contributions and if you need help with fixing the CICD build failures please message here. https://docs.godotengine.org/en/stable/community/contributing/pr_workflow.html |
efc7282
to
2261f16
Compare
Add two new functions to the IP class that returns all addresses/aliases associated with a given address. This is a cherry-pick merge from 010a343 which was merged in 2.1, and has been updated to build with the latest code. This merge adds two new methods IP.resolve_hostname_addresses and IP.get_resolve_item_addresses that returns a List of all addresses returned from the DNS request.
2261f16
to
dd8fa11
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! 👍
Thanks! And congrats for your first merged Godot contribution 🎉 |
EDIT: Opened an issue #49261, original comment below: This PR breaks file downloading (e.g. export templates downloading in the editor). The download stops at an unassuming status If Code that doesn't work: download_templates->set_download_file(EditorPaths::get_singleton()->get_cache_dir().plus_file("tmp_templates.tpz"));
download_templates->set_use_threads(true);
Error err = download_templates->request(p_url); But requests like this do work: request_mirror->request("https://godotengine.org/mirrorlist/" + p_version + ".json"); Any ideas? |
I had a quick go at cherry-picking this + #49269 for |
#49020 has that commit; admittedly it isn't up to date with the MutexLock fix (I can do that quickly). Is that one still good enough? |
Ah yes, please update it to address feedback from this PR if relevant, and include the regression fix. |
Add two new functions to the IP class that returns all addresses/aliases associated with a given address.
This is a cherry-pick merge from 010a343 which was merged in 2.1, and has been updated to build with the latest code.
This merge adds two new methods IP.resolve_hostname_addresses and IP.get_resolve_item_addresses that returns a List of all addresses returned from the DNS request.