Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename is_valid_integer() to is_valid_int() #49659

Merged
merged 1 commit into from
Jun 18, 2021
Merged

Rename is_valid_integer() to is_valid_int() #49659

merged 1 commit into from
Jun 18, 2021

Conversation

AaronRecord
Copy link
Contributor

Method from String

Closes godotengine/godot-proposals#2866

@AaronRecord AaronRecord requested review from a team as code owners June 16, 2021 16:29
@AaronRecord AaronRecord force-pushed the string-valid-integer-to-int branch from 408c488 to d0fa1d9 Compare June 16, 2021 16:31
@AaronRecord AaronRecord force-pushed the string-valid-integer-to-int branch from d0fa1d9 to b6af2a2 Compare June 16, 2021 16:32
@Calinou Calinou added this to the 4.0 milestone Jun 16, 2021
@akien-mga akien-mga merged commit 92f20fd into godotengine:master Jun 18, 2021
@akien-mga
Copy link
Member

Thanks!

@AaronRecord AaronRecord deleted the string-valid-integer-to-int branch June 18, 2021 14:18
@raulsntos raulsntos mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
breaks compat enhancement topic:core
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.

Rename String's to_int() or is_valid_integer() so they match
3 participants
@AaronRecord @akien-mga @Calinou