[4.0] Platform export refactoring #50771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4gr3d
approved these changes
Jul 23, 2021
akien-mga
approved these changes
Aug 12, 2021
|
Needs a rebase, otherwise seems good to merge. |
naithar
force-pushed
the
feature/platform-export-refactoring-4.0
branch
from
67f60f0 to
253581f
Compare
|
Thanks! |
This was referenced Jan 17, 2022
This was referenced Jul 3, 2022
aaronfranke
reviewed
Jul 17, 2022
Comment on lines
+313
to
+315
| } else if (mode == EXPORT_MODE_GDNATIVE) { | ||
| r_features->push_back("wasm32"); | ||
| } |
There was a problem hiding this comment.
What's the reason to not just always have wasm32 as an export feature for the JavaScript platform?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous PR: #50467
Another approach at export refactoring proposal: godotengine/godot-proposals#2929 that was suggested there.
Allows to use
.cppfiles other thanexport.cppfor platform's export template. Keeps current structure where export folder and it's code is kept with platform.export.cppfiles for each platform are also separated into more files for initial refactoring.Future PRs could bring more changes to exports to cleanup the code and make it easier to navigate.