Remove infinite inertia and ray shapes from CharacterBody #51490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Infinite inertia: Not needed anymore, since it's now possible to set one-directional collision layers in order for characters to ignore rigid bodies, while rigid bodies still collide with characters. Ray shapes: They were introduced as a work around to allow constant speed on slopes, which is now possible with the new property in CharacterBody instead.
|
@TokageItLab You were interested in the upward staircase movement? Does this solve that? |
|
@fire Probably no. First we need to solve the problem of jittering to slipping down the slope described in the comment and #50756. I was only suggesting the possibility that a side effect of that (preventing jitter) might be the impossibility of climbing low steps. |
akien-mga
approved these changes
Aug 11, 2021
|
Thanks! |
This was referenced Aug 11, 2021
This was referenced Aug 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Infinite inertia:
This option allowed kinematic bodies to ignore collision with rigid bodies and push them.
It's not needed anymore, since it's now possible to set one-directional collision layers in order for characters to ignore rigid bodies, while rigid bodies still collide with characters.
PRs: #42641 & #50625
Ray shapes:
They were introduced as a workaround to allow constant speed on slopes, which is now possible in a more flexible way using the new property
constant_speed_on_floorinCharacterBody.PR: #51027