Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused imports default_theme SCsub #53925

Merged
merged 1 commit into from
Oct 18, 2021

Conversation

Anutrix
Copy link
Contributor

@Anutrix Anutrix commented Oct 17, 2021

Removes unused imports from default_theme's SCsub script.

Vulture(https://pypi.org/project/vulture/):

find . -name "*.py" -o -name "SCsub" -o -name "SConstruct" | xargs vulture | grep "unused import"

showed 0 results.

LGTM(https://lgtm.com/projects/g/godotengine/godot/alerts?mode=list&severity=&id=py%2Funused-import) had just those 2 unused imports in default_theme's SCsub script.

Autoflake(https://pypi.org/project/autoflake/) that uses pyflakes:

find . -name "*.py" -o -name "SCsub" -o -name "SConstruct" | xargs vulture | grep "unused import"

showed above and 4 more results in 3 more files.

Do suggest any other tool for static analysis.

@Anutrix Anutrix requested a review from a team as a code owner October 17, 2021 16:40
@Calinou Calinou added enhancement topic:buildsystem cherrypick:3.x Considered for cherry-picking into a future 3.x release labels Oct 17, 2021
@Calinou Calinou added this to the 4.0 milestone Oct 17, 2021
@Calinou
Copy link
Member

Calinou commented Oct 17, 2021

It might be worth checking for unused imports in all Python files (**/*.py, **/SCsub, **/SConstruct).

@Anutrix Anutrix force-pushed the fix-unused-imports branch from bcd9f65 to a4b7366 Compare October 17, 2021 20:21
@Anutrix Anutrix requested review from a team as code owners October 17, 2021 20:21
@Anutrix
Copy link
Contributor Author

Anutrix commented Oct 17, 2021

It might be worth checking for unused imports in all Python files (**/*.py, **/SCsub, **/SConstruct).
Done.
Updated main comment.

@akien-mga akien-mga merged commit 523e0d8 into godotengine:master Oct 18, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga
Copy link
Member

Cherry-picked for 3.4.

@akien-mga akien-mga removed the cherrypick:3.x Considered for cherry-picking into a future 3.x release label Oct 18, 2021
@Anutrix Anutrix deleted the fix-unused-imports branch July 26, 2022 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants