3.x: Fix validation errors due to chunk padding and empty skins. #54250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lyuma
force-pushed
the
gltf_padding_fix_3.x
branch
2 times, most recently
from
51fa465 to
b6e3873
Compare
GLB chunk padding length calculation was backwards and missing for the BIN chunk. Fixed error caused by "skins":[] when no skins were present. Finally, encode animations before textures to avoid accessor misalignment due to texture byteLength.
lyuma
force-pushed
the
gltf_padding_fix_3.x
branch
from
b6e3873 to
e49f8c5
Compare
akien-mga
approved these changes
Oct 26, 2021
|
Thanks! |
|
Tested it on latest 3.x build @lyuma and it's great to see that models are now exporting to Blender, but unfortunately there are no materials attached |
|
Just to avoid fragmenting the discussion, I'm following up over at #51132. If you are able to provide precise reproduction steps, we can reopen that bug, or make a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #54249
Fixes #51132 and #54251