Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for RID class. #54325

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Add unit tests for RID class. #54325

merged 1 commit into from
Aug 4, 2022

Conversation

skimmedsquare
Copy link
Contributor

Addresses a task of #43440

@skimmedsquare skimmedsquare requested a review from a team as a code owner October 27, 2021 22:24
@Calinou Calinou added this to the 4.0 milestone Oct 27, 2021
@skimmedsquare
Copy link
Contributor Author

Updated to fix clang-format issues.

@Calinou Calinou mentioned this pull request Jan 30, 2022
Open
99 tasks
akien-mga
akien-mga approved these changes Aug 4, 2022
View reviewed changes
Copy link
Member

@akien-mga akien-mga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay reviewing this.

I force pushed an update to rebase, update the license header, and move the file to the new expected location.

This should be good to merge if it passes CI.

@akien-mga akien-mga merged commit 255e077 into godotengine:master Aug 4, 2022
@akien-mga
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:tests
Projects
None yet
Milestone
4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@skimmedsquare @akien-mga @Calinou