Fix TileSet editor workspace breaking #55059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Nov 17, 2021
| @@ -3336,7 +3336,7 @@ void TileSetEditor::update_workspace_minsize() { | |||
| } | |||
| } | |||
|
|
|||
| workspace->set_custom_minimum_size(workspace_min_size + WORKSPACE_MARGIN * 2); | |||
| workspace->call_deferred("set_custom_minimum_size", workspace_min_size + WORKSPACE_MARGIN * 2); | |||
There was a problem hiding this comment.
If you know why this fixes it, might be worth adding a comment to document it.
There was a problem hiding this comment.
Commented, although I don't exactly know why it works. The problem here was probably that workspace isn't inside any container, so it's very sensitive to size changes, and especially change order. But simply moving the line to the bottom didn't fix it, the call had to be deferred to work, which is weird. It's not the first time a random call_deferred() fixed a bug though 🙃
KoBeWi
force-pushed
the
call_deferred_to_the_rescue
branch
from
7917acc to
f3d5ef6
Compare
akien-mga
approved these changes
Nov 17, 2021
|
Thanks! |
|
Cherry-picked for 3.4.1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #52760