Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix right alignment in RichTextLabel #55439

Merged
merged 1 commit into from
Nov 29, 2021
Merged

Fix right alignment in RichTextLabel #55439

merged 1 commit into from
Nov 29, 2021

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Nov 29, 2021

Fixes #54764

@KoBeWi KoBeWi added this to the 3.5 milestone Nov 29, 2021
@KoBeWi KoBeWi requested a review from a team as a code owner November 29, 2021 13:07
@YuriSizov
Copy link
Contributor

Does it fix #54551?

@bruvzg
Copy link
Member

bruvzg commented Nov 29, 2021

Does it fix #54551?

No, it's not fixing it, probably some other int → float are still missing.

@KoBeWi KoBeWi force-pushed the random_programming_ftw branch from e8109b3 to 820f7c9 Compare November 29, 2021 13:33
@KoBeWi
Copy link
Member Author

KoBeWi commented Nov 29, 2021

I checked #54551 and it's not obvious where to look for the fix. This PR makes the issue less severe though.

@bruvzg
Copy link
Member

bruvzg commented Nov 29, 2021

Here's a fix for the #54551 - #55440.

@akien-mga akien-mga merged commit eb5c2e1 into godotengine:3.x Nov 29, 2021
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga mentioned this pull request Nov 29, 2021
Closed
@KoBeWi KoBeWi deleted the random_programming_ftw branch November 29, 2021 14:03
@akien-mga
Copy link
Member

Cherry-picked for 3.4.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

@bruvzg bruvzg bruvzg approved these changes

Assignees
No one assigned
Labels
bug regression topic:gui
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
4 participants
@KoBeWi @YuriSizov @bruvzg @akien-mga