[3.x] Godot Physics AreaSW and Area2DSW: fix premature return in call_queries
#58531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
call_queriesmethod (ofAreaSWand ofArea2DSW) does two things: one for monitored bodies and one for monitored areas. However, if the null check in the part about bodies fails, then the method returned, and hence skipped the part about areas (which is an independent part).This PR fixes the premature
return, by bringing the structure of the code in sync withmaster(compare e.g.GodotArea2D::call_queries()inmaster). Hence this PR is only for3.xand not relevant formaster.