Convert the editor and default theme fonts to WOFF2 format to save space. #59510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Mar 25, 2022
akien-mga
reviewed
Mar 25, 2022
| * Upstream: https://github.com/googlefonts/noto-fonts | ||
| * Version: v2017-10-24-phase3-second-cleanup | ||
| * License: OFL-1.1 | ||
| * Comment: Use UI font variant if available, because it has tight vertical metrics and | ||
| good for UI. | ||
| - `JetBrainsMono_Regular.ttf`: | ||
| - `JetBrainsMono_Regular.woff2`: |
There was a problem hiding this comment.
I don't know if that makes any significant difference, but JetBrains seem to provide a woff2 version of the font themselves: https://github.com/JetBrains/JetBrainsMono/blob/master/fonts/webfonts/JetBrainsMono-Regular.woff2
There was a problem hiding this comment.
It's probably not, WOFF is just a compressed wrapper, all font structures should stay the same. Their version is 3 KB larger, but it probably depends only on a tool that was used to compress it.
akien-mga
approved these changes
Mar 25, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes an editor executable about 5.2 MB smaller. I was not able to notice any change in loading speed, or any visual differences.