Add test cases for AudioStreamWAV #60736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
StrawbDev
force-pushed
the
audio-stream-sample-unit-test
branch
from
25cadb4 to
354d7c4
Compare
akien-mga
changed the title
akien-mga
force-pushed
the
audio-stream-sample-unit-test
branch
from
354d7c4 to
3c252d5
Compare
akien-mga
approved these changes
Aug 4, 2022
There was a problem hiding this comment.
Apologies for the late review.
This looks great! I force pushed an update to rename Sample to WAV following #60957.
I also tweaked the test to initialize the AudioServer in test_main.cpp to match only on Audio so we can use it for future audio-related tests. This calls for some refactoring eventually so that tests can be responsible for registering what kind of additional features they need, but that's not critical for now.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #43440
This PR adds tests for AudioStreamSample, mostly to check the
save_to_wav()method. This needs the AudioServer running for it to work, so I modified the test case listener intest_main.cppto start AudioServer with the dummy driver for these tests. The saved .wav files are checked using ResourceImporterWAV, but that is only available if compiling with tools enabled. This is my first PR for Godot so if there are any problems with this please let me know :)