Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.x] Add viewport content scale #60830

Merged
merged 1 commit into from
Jun 3, 2022
Merged

Conversation

Ansraer
Copy link
Contributor

@Ansraer Ansraer commented May 6, 2022

This PR should make it possible to scale up content with the content scale factor when the stretch mode is set to viewport. This should fix #60801.

I am fairly certain that I had a reason why I didn't include this in #52170, but really can't remember what it was. Did some quick testing and couldn't find any obvious major problems with this. 🤷

Test project: https://github.com/Calinou/godot-demo-projects/tree/multiple-resolutions-update-to-4.0/gui/multiple_resolutions?rgh-link-date=2022-05-05T17%3A37%3A13Z

@Ansraer Ansraer requested a review from a team as a code owner May 6, 2022 17:57
@Calinou Calinou added this to the 4.0 milestone May 6, 2022
@Sauermann
Copy link
Contributor

Sauermann commented May 7, 2022

Also tested it and found no issues.
Here is my MRP: WindowsTestbed.zip

According to https://docs.godotengine.org/en/latest/tutorials/rendering/multiple_resolutions.html, the Stretch Mode = Viewport should take the "Stretch Aspect setting into account".

I will need to test, if this interferes with #59310.

@akien-mga akien-mga merged commit 659f4b6 into godotengine:master Jun 3, 2022
@akien-mga
Copy link
Member

Thanks!

@Ansraer Ansraer deleted the fix-2d-scale branch June 3, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0alpha: Stretch scale factor doesn't apply when using viewport stretch mode (while it does in 3.x)
4 participants