Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable scroll when dragging at edges of TextEdit #61980

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Disable scroll when dragging at edges of TextEdit #61980

merged 1 commit into from
Jun 14, 2022

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Jun 12, 2022

Fixes #59822

I checked on master and this function doesn't seem to work properly, so I guess that's why this bug doesn't appear lol.

@KoBeWi KoBeWi added this to the 3.x milestone Jun 12, 2022
@KoBeWi KoBeWi marked this pull request as ready for review June 13, 2022 00:03
@KoBeWi KoBeWi requested a review from a team as a code owner June 13, 2022 00:03
@ConteZero
Copy link
Contributor

I think that scroll when dragging at edges should be disabled only if text_editor/cursor/scroll_past_end_of_file is enabled on the editor.

@KoBeWi KoBeWi force-pushed the obliterate_scroll branch from 5522a25 to 053fdb8 Compare June 14, 2022 21:37
@KoBeWi
Copy link
Member Author

KoBeWi commented Jun 14, 2022

Done.

@akien-mga akien-mga merged commit 0c5c538 into godotengine:3.x Jun 14, 2022
@akien-mga
Copy link
Member

Thanks!

@akien-mga akien-mga modified the milestones: 3.x, 3.5 Jun 14, 2022
@akien-mga akien-mga mentioned this pull request Jun 14, 2022
Closed
@KoBeWi KoBeWi deleted the obliterate_scroll branch June 14, 2022 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
bug regression topic:editor usability
Projects
None yet
Milestone
3.5
Development

Successfully merging this pull request may close these issues.
3 participants
@KoBeWi @ConteZero @akien-mga