Input: Document that accumulated input is disabled by default #62664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was actually disabled by mistake in 3.4 causing a regression, but since this issue survived the whole 3.4.x series and it's now very close to 3.5, it's too late to change it again. We might consider it for 3.6 after some beta testing. Fixes godotengine#55037.
akien-mga
added a commit
to akien-mga/godot
that referenced
this pull request
Jul 3, 2022
I turned it off by mistake in godotengine#38697. See also godotengine#62664 for details on this boolean's complex history :)
|
Cherry-picked for 3.4.5. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was actually disabled by mistake in 3.4 causing a regression, but since
this issue survived the whole 3.4.x series and it's now very close to 3.5,
it's too late to change it again.
We might consider it for 3.6 after some beta testing.
Some more details on the defaults here:
EditorNode). This was changed in Godot 3.4.master(which started diverging with3.xat Godot 3.2), [3.x] Improve responsiveness on underpowered Android devices #42220 was forward-ported by Input buffering framework + Leverage on Android #51597 but accumulated input was not turned off then. On the other hand... I turned it off by error myself in Port member default initialization from constructor to declaration (C++11) #38697 while refactoring member initialization. Input: Re-enable input accumulation by default #62665 should fix it.