Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability for extensions to clear object instance bindings #67285

Closed
wants to merge 1 commit into from

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Oct 11, 2022

Required for godotengine/godot-cpp#892.

This change adds Object::clear_instance_binding which is meant to let (generated) extension code clear/unset the instance binding that gets created for engine singletons in Object::get_instance_binding.

See godotengine/godot-cpp#892 for more details on its usage.

@mihe mihe requested review from a team as code owners October 11, 2022 23:19
@mihe mihe force-pushed the singleton-cleanup branch 2 times, most recently from 4adcd63 to 30a742a Compare October 12, 2022 22:25
@Calinou Calinou added this to the 4.0 milestone Oct 12, 2022
@mihe mihe force-pushed the singleton-cleanup branch 3 times, most recently from b4e31fd to 77e563c Compare October 16, 2022 20:59
@mihe mihe force-pushed the singleton-cleanup branch from 77e563c to b2a4d7e Compare October 30, 2022 14:03
@mihe mihe force-pushed the singleton-cleanup branch from b2a4d7e to 75488b4 Compare November 18, 2022 13:21
@mihe mihe force-pushed the singleton-cleanup branch from 75488b4 to 5871ac8 Compare December 9, 2022 13:56
@mihe mihe force-pushed the singleton-cleanup branch from 5871ac8 to 76e75ff Compare December 13, 2022 17:38
@YuriSizov YuriSizov modified the milestones: 4.0, 4.1 Feb 10, 2023
@mihe mihe closed this Mar 25, 2023
@mihe mihe deleted the singleton-cleanup branch March 25, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants