Ensure vulkan subgroups are disabled for MoltenVK #67915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Oct 26, 2022
servers/rendering/renderer_rd/shaders/forward_clustered/scene_forward_clustered.glsl
Outdated
Show resolved
Hide resolved
We found they don't work on intel macbooks properly at all. Possible future solutions: - update to moltenvk. - update to spirv may resolve it.
RevoluPowered
force-pushed
the
fix-intel-macbook-crash-subgroups
branch
from
53d105f to
381d457
Compare
clayjohn
approved these changes
Oct 28, 2022
|
Yeah, let's keep an eye on this to be sure we do the right thing. Aside, the changes about unsigned correctness would belong in a separate commit/PR, but I wouldn't block merging on that. Just for next time. |
|
I'll merge for beta 4. For beta 5, I'll be updating all our Vulkan components to the latest Vulkan SDK released a week ago (including new MoltenVK and I've seen mentions of regression fixes), so please test again then and see if this is still needed. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We found they don't work on intel macbooks properly at all.
Possible future solutions: