Revert removal of GDNativeExtensionScriptInstanceInfo::get_property_type_func in GDExtension #68549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ype_func in GDExtension This function pointer is needed to stay close to internal Godot's ScriptInstance class. Besides, by removing this function pointer, we had to do property list create/free each time we want to access type which is quadratic complexity :/
touilleMan
force-pushed
the
gdextension-revert-get_property_type_func-removal
branch
from
fcf9f1e to
39c039a
Compare
akien-mga
approved these changes
Nov 12, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverting the change on
GDNativeExtensionScriptInstanceInfoI made in #67750, I thought it would be simpler to have a similar interface betweenGDExtensionandGDNativeExtensionScriptInstanceInfo, but after deeper investigation it turns out it is much better to haveGDNativeExtensionScriptInstanceInfobeing just a proxy over Godot's internalScriptInstance.Besides, by removing this function pointer, we had to do property list create/free each time we want to access type which is quadratic complexity :/ (and implementing a cache on this is complex given property can be dynamically modified)