-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use forward-declarations in big editor classes #69062
Use forward-declarations in big editor classes #69062
Conversation
d8459b7
to
c5c48dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup again.
I noticed you added some new includes in some .h
files (editor node, canvas item editor, script text editor etc.). I assume you plan to handle them in follow-up PR(s)?
Not really. They need non-trivial refactoring (and in some cases you can't e.g., with subclasses), which I don't plan to do. What I'll do in follow-up PRs is to further forward declare stuff. |
But includes are only needed when you inherit the class or define a method inside header. I checked these files and it doesn't seem to be the case there. |
EditorData doesn't agree with you 😀
Another thing that can't be included are enums defined in classes. This is why, e.g., EditorNode needs |
c5c48dd
to
f13664d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs a rebase to solve a merge conflict, otherwise should be good to merge.
f13664d
to
e03eaa8
Compare
e03eaa8
to
c90d0bd
Compare
Thanks! |
Follow up of #60684
Reduce the number of includes in some editor classes that are included a lot.
Add forward declarations in touched headers.
Remove some unused includes.