Fix mobile and gl_compatibility renderers sky_transform operations
#69636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clayjohn
reviewed
Dec 6, 2022
24 tasks
… the same order as the forward_plus renderer. Update rasterizer_scene_gles3.cpp Apply sky_transform order fix to the gles3 renderer.
Malcolmnixon
force-pushed
the
vulkan-mobile-sky-matrix
branch
from
73d1f3b to
0f8a968
Compare
|
As requested I applied the sky_transform order fix to the gles3 renderer. Visual inspection shows it has the same transform-ordering bug, but I cannot confirm whether the fix worked because the sky just shows as gray when I switch to the gl_compatibility renderer. |
akien-mga
approved these changes
Dec 6, 2022
|
Thanks! And congrats for your first merged Godot contribution 🎉 (in this repo at least ;)) |
akien-mga
changed the title
sky_transform operations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes issue #69630 by performing the sky_transform operations in the same order as performed for the forward_plus renderer. These changes are the same transform-fix that was performed in #61859, but applied in the new mobile renderer code.
Bugsquad edit: