mbedtls: Update to upstream version 2.28.2 #70395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
added
bug
topic:thirdparty
cherrypick:3.x
akien-mga
commented
Dec 21, 2022
Comment on lines
+10
to
+11
| +// -- GODOT start -- | ||
| +#if !defined(HAVE_HARDCLOCK) && defined(_WIN32) && \ |
There was a problem hiding this comment.
@bruvzg We need to PR that change upstream so we don't have to keep applying a patch here.
I'm not sure this would be the right/sufficient fix but if not, opening an issue upstream with the build error you encounter on MSVC arm64 would be good.
There was a problem hiding this comment.
Should be already fixed by Mbed-TLS/mbedtls#4640
There was a problem hiding this comment.
That's weird because that PR was backported to 2.28 in April, so it should have been included in our build at the time you wrote this patch.
|
Cherry-picked for 3.6. |
akien-mga
removed
the
cherrypick:3.x
|
Cherry-picked for 3.5.2. |
akien-mga
removed
the
cherrypick:3.5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.