Converter: Rename 3.x Vector2 clamped to limit_length
#73971
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
reviewed
Feb 26, 2023
editor/renames_map_3_to_4.cpp
Outdated
| @@ -579,7 +579,7 @@ const char *RenamesMap3To4::gdscript_function_renames[][2] = { | |||
| // Remember to add them to the builtin_types_excluded_functions variable, because for now these functions cannot be listed. | |||
| // { "empty", "is_empty" }, // Array -- Used as custom rule. Be careful, this will be used everywhere. | |||
| // { "remove", "remove_at" }, // Array -- Breaks Directory and several more. | |||
| { "clamped", "clamp" }, // Vector2 -- Be careful, this will be used everywhere. | |||
| { "clamped", "limit_length" }, // Vector2 -- Doc already said for 3.5 clamped is deprecated and limit_lenght should be used | |||
There was a problem hiding this comment.
The comment (and the commit message) has a typo, but I'd simply remove it, it's the correct rename and doesn't require justification in the code.
There was a problem hiding this comment.
thank you for the input, I reverted the comment to what it was previously. I am 100% sure the rename is correct after this change, but would expect to get confirmation from anyone else
akien-mga
changed the title
clamped to limit_length
|
Looks good! Could you squash the commits? See PR workflow for instructions. |
|
happy to oblidge |
akien-mga
approved these changes
Feb 26, 2023
|
The CI failed due to a workaround that needed to be updated, so I amended the commit to fix it up, and also added the missing C# conversion. |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doc already said for 3.5 clamped is deprecated and limit_lenght should be used, clamp is the wrong function