-
-
Notifications
You must be signed in to change notification settings - Fork 21.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 3D Viewport Front/Rear axis and Focus button #76052
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regardless on the discussion about look_at
being confusing, this PR makes Godot work consistently with every other 3D software (CAD, 3D Modelling or game engine), so the front/back views look at the right side of the model. Currently they are flipped.
|
I just checked what Unity and Unreal do.
Unity vs current Godot: Unity and Unreal both have a consistent forward direction, unlike Blender which does not have a consistent forward direction. Godot in the current master is self-consistent and consistent with how Unity and Unreal work but inconsistent with Blender. This PR would change it to be consistent with how Blender works but not self-consistent and inconsistent with how Unity and Unreal work. By self-consistent I mean that front/right/etc always refer to the same relative directions. EDIT: To respond to reduz below saying Godot is swapped respect to "any other software"... what about Unity and Unreal, which the current Godot is consistent with, and all are consistent with themselves? |
This needs to be merged because Godot is plain broken. Front/Back are swapped respect to any other software @aaronfranke I understand your wish to have consistency in this aspect, but having something that mimics Blender is better in practice for us and our users, even if Blender is not consistent. The reasoning in Blender is very smart, its what you would get if you rotate the object in the desired direction and its more on the intuitive than in the consistent side. I much prefer that. |
@aaronfranke I am going to repost this set of comparison images that I posted in the closed PR. Every 3d dcc on the planet adheres to the same relative top/front/right/left conventions. It is not relevant which coordinate system they use, it is about the artistic expectation of the front and left/right views as compared to the top view. These are screenshots I took from Blender, Houdini and Cinema4D. Even though they all have different coordinate systems, the ortho views are relatively the same. Cinema4D actually does have the same coordinate system as Godot. The small red cube is in front of the large cube when seen from the top view. This is what it looks like in Godot with the reverted PR, and can be seen to be consistent. |
@fracteed The last picture is incorrect, I guess the actual current Godot 4 has its left and right reversed (I also fixed that in #75921). And that meant that Godot which is supposed to be a right-handed coordinate system, suddenly has a left-handed coordinate system. In any case, this PR will revert the view to what it should be. |
@TokageItLab yes, the last picture is the incorrect one, and is from a current 4.0 build. The previous image (that lines up with all the others) was from a github autobuild that I tried previously with your PR. So, has it changed since yesterday? |
@fracteed I meant #75921 to fix the front/back when that option is true, and also to fix the left/right which was like a left-handed coordinate system when that option is false. This PR simply fixes the front and back only. Now the view will revert to the right hand coordinate system and capture +Z of the model from the front. |
@TokageItLab I just redownloaded the artifact from this PR to retest. I still get the same correct result. Looks fine to me. Presumably this is what you intended? |
Yes ... but I personally think that such (expert) options in already crowded places will only bring xx k additional bugs and mind-dead-locks to Godot. The mainstream should rather focus on getting the standard open chains like svg, glTF and many others to work without errors. We have unfortunately bugs in every corner here ... |
I have to agree with @capnm, at the very least the option should be somewhere VERY prominent |
This reverts commit f995d6c.
5a24f4d
to
4e4259b
Compare
Thanks! |
Supersedes #75921.
We've discussed this with reduz in contributors chat. Revert the commit #45669 that caused it.
There will be additional forward and backward documentation by reduz later.
Includes a fix for an issue that broke the drawing of the Focus button in the upper right corner when in an Othro view parallel to the axis. Also front and rear button index was wrong, fixed.