-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix paste value not updated in dictionaries/arrays (reverted) #76711
Fix paste value not updated in dictionaries/arrays (reverted) #76711
Conversation
Does this risk causing too frequent updates when editing arrays and dictionaries? |
I don't think it will cause too frequent updates but it will effectively call more updates then needed as it will call a full inspector rebuild of the edited property. What I mean is that instead of updating only the dictionnary/array editor it will update the full property of the edited object while the dictionary might only be a small part of it. I'll make an update so that it only calls Edit : Re-checked and effectively it would have called way more frequent updates because most |
24dab9d
to
308f38e
Compare
308f38e
to
6f596ee
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally (rebased against master
a83eb16), it works.
Thanks! |
This PR introduced the issue, that it is no longer possible to select a different entry-field by mouse-click after editing. BugClickNoFocus.mp4 |
Fixes #75124
when a value of a Dictionarry/array was modified it would never call
update_property
asemit_changed
was called withp_changing == true
whatever the case.Edit : forced the call directly to
update_property
whenp_changing == false
. This will update less and will make it work fornew_item
key and value which I didn't think of previously.With this new approach #76795 is not fixed anymore