Fix VideoStreamPlayer seamless loop #77856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 4, 2023
KoBeWi
reviewed
Jun 5, 2023
KoBeWi
approved these changes
Jun 5, 2023
|
As requested in the contributors chat, here is an audio sample of the VideoStreamPlayer looping seamlessly (warning, might be loud). Audio being looped: Resulting output from Godot: Note that depending on CPU load and complexity of the audio, it still might crack. |
kinami-imai
force-pushed
the
videostreamplayer_seamless_loop
branch
from
9c53c31 to
270bc93
Compare
|
Force pushing changes of @KoBeWi to keep git history clean 🙂 |
|
Thanks! And congrats on your first merged Godot PR! |
kinami-imai
added a commit
to kinami-imai/godot-docs
that referenced
this pull request
Jun 6, 2023
As no workarounds are necessary to seamlessly loop videos since godotengine/godot#77856 got merged.
|
Very nice! Waiting for this thing for like 4 Years to happen XD |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of a group of three PRs (#77856 #77857 #77858) that solve godotengine/godot-proposals#264.
This PR enables seamless looping in VideoStreamPlayer nodes with connecting the
on_finishedsignal to theplay()function. Currently doing this will result in a blank frame due to the fact that the internal processing trigger only fires again on the next frame, which means the draw call on the current frame will draw an empty texture. With this change the texture is already updated with the newly started playback, which renders the first frame to the texture instead of leaving it blank, eliminating the one frame flash of transparency of the previous implementation.Before (note the flash of background when the loop restarts):
before.mp4
After (no flash of background):
after.mp4