-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve depth buffer in mobile renderer when required #78598
base: master
Are you sure you want to change the base?
Resolve depth buffer in mobile renderer when required #78598
Conversation
d4b4f44
to
db2e8d9
Compare
I need to do some more testing but I think this also solves #78544 |
I think there should be 100% a fallback as the mobile renderer works better on older pc and it also has to support mobile, which nowadays it vulkan support is not the best. |
@Saul2022 agreed though I'd like to mark all the "todos" for future PRs. This is an important fix I'd like to get into 4.1 and the fix window closes Monday. As currently resolving doesn't work plus we have a number of validation errors that are solved by this, this is a step forward and shouldn't break anything that isn't already broken. @clayjohn @akien-mga I'm marking this for review due to the above reason if you guys are ok with that. |
As discussed on chat, let's not rush it now, but this is a good candidate for 4.1.1 once finalized and merged for 4.2. |
Does this resolve #78785? |
@Calinou I don't think so, but that is one I need to find time for |
db2e8d9
to
b3c9081
Compare
b3c9081
to
f12e564
Compare
Is this still getting merged? I also got the same issue on my XR project so I wonder if there are any workarounds too. |
This PR fixes a long standing issue with the mobile renderer when using MSAA. The subpass logic never had an option for resolving the MSAA depth buffer to a normal depth buffer.
This meant that:
This PR does rely on the VK_KHR_depth_stencil_resolve extension. This has been core since Vulkan 1.2 and was a KHR extension in Vulkan 1.0/1.1 and may not be supported on all GPUs.
Todos: