-
-
Notifications
You must be signed in to change notification settings - Fork 21.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose RenderSceneBuffers(RD) through ClassDB #79142
Expose RenderSceneBuffers(RD) through ClassDB #79142
Conversation
I'm also wondering if we should remove if we should remove the |
4f3b306
to
a8bbdd8
Compare
Decided to split off Also decided to keep the |
edit rebasing helped :) |
ce29e5d
to
bee15d0
Compare
After discussing with @reduz on contributors chat, decided to register |
bee15d0
to
781a118
Compare
In order to make this more easily usable I've exposed In order to make this work I've moved the MSAA buffer creation back into the I've also added access to the velocity texture. |
781a118
to
8a8acbb
Compare
YAAAY! |
servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work so far! I left some comments.
servers/rendering/renderer_rd/storage_rd/render_scene_buffers_rd.cpp
Outdated
Show resolved
Hide resolved
ah I approved by accident, it looks good but I would change this specifically. |
8a8acbb
to
36151fa
Compare
36151fa
to
4874b96
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me too!
Thanks! |
In preparations of planned work around exposing some internals of the rendering engine, this PR completes the bind methods implementation of the
RenderSceneBuffer
andRenderSceneBufferRD
objects.Q: Should we rename
RenderSceneBufferRD
toRDRenderSceneBuffer
to be inline with the other exposed rendering device objects?