GLTF: Preserve the original bytes when extracting a texture while importing #79533
Conversation
aaronfranke
force-pushed
the
gltf-image-keep-bytes
branch
from
18ead49 to
4fa0f6d
Compare
| @@ -3078,15 +3078,18 @@ Ref<Image> GLTFDocument::_parse_image_bytes_into_image(Ref<GLTFState> p_state, c | |||
| Error err = ext->parse_image_data(p_state, p_bytes, p_mime_type, r_image); | |||
| ERR_CONTINUE_MSG(err != OK, "GLTF: Encountered error " + itos(err) + " when parsing image " + itos(p_index) + " in file " + p_state->filename + ". Continuing."); | |||
| if (!r_image->is_empty()) { | |||
| r_file_extension = ext->get_image_file_extension(); | |||
There was a problem hiding this comment.
doesn't this need to pass in p_index ? Or is it expected that a given extension only handles exactly one image format.
There was a problem hiding this comment.
The code expects that one GLTFDocumentExtension handles importing one kind of image format (can be "multiple formats" with one file extension like Lossy WebP and Lossless WebP). If multiple file extensions are needed, it's not a big deal for a plugin/add-on to supply multiple GLTFDocumentExtension classes. In fact that's probably for the best since it would keep the code of multiple image formats separated. Note that the import code checks each image individually so it may be the case that multiple GLTFDocumentExtensions are used to import one glTF file.
aaronfranke
force-pushed
the
gltf-image-keep-bytes
branch
from
4fa0f6d to
2d13a96
Compare
|
Thanks! |
Before this PR, the GLTF importer will import images into an Image resource, and then use this to save a PNG file to disk. This means that JPG, WebP, etc images would be converted to PNG, using more disk space than necesssary, and being slower than necessary since it needs to re-encode the images.
As of this PR, when the importer wants to save the images to separate files, the image data in the GLTF will just be directly written to disk, for PNG and JPG always, and for other image formats it will save it into a file when the GLTFDocumentExtension defines
get_image_file_extensionto indicate what the file extension should be.To be clear, preserving the original bytes for new image formats is optional (for the extension programmer). If a GLTFDocumentExtension class wants to import images and have Godot save them as PNG, just don't define
get_image_file_extension. When this method is not defined, Godot will save an Image resource as a PNG like before.Some test files I used with JPG/PNG/WebP all are extracted correctly: