Add path to missing import texture metadata to error message #80107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
added
enhancement
topic:editor
cherrypick:4.1
|
Apologies, accidentally closed the last PR for this change. Recreated here on a separate branch. Here's the original PR: #79744 |
AThousandShips
changed the title
AThousandShips
changed the title
YuriSizov
approved these changes
Aug 1, 2023
|
Thanks! And congrats on your first merged Godot PR! For the record, if you accidentally close a PR, you can always reopen it and push any changes you want to the same branch. |
Thanks and hopefully more to come soon =D
Will keep this in mind! |
|
Cherry-picked for 4.1.2. |
YuriSizov
removed
the
cherrypick:4.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the error message would just warn that a texture needed to be reimported but would not list which texture. This change adds the file path to the error output for the
Missing required editor-specific import metadata for a texture; please, reimportmessage and updates the sentence structure.Now changed to
Missing required editor-specific import metadata for a texture (please reimport it using the 'Import' tab): FILE_PATHfixes: #79550