CI: Compare API compatibility against both 4.0 and 4.1 #80354
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RedworkDE
force-pushed
the
ci-compat-multi
branch
from
fe87615 to
9fa98b2
Compare
|
This approach seems good to me! |
RedworkDE
force-pushed
the
ci-compat-multi
branch
from
9fa98b2 to
7af89d3
Compare
akien-mga
approved these changes
Aug 30, 2023
RedworkDE
force-pushed
the
ci-compat-multi
branch
from
7af89d3 to
97dc955
Compare
RedworkDE
force-pushed
the
ci-compat-multi
branch
from
97dc955 to
4dfff3e
Compare
RedworkDE
commented
Aug 30, 2023
Comment on lines
+115
to
+116
| Validate extension JSON: API was removed: classes/GLTFDocumentExtensionPhysics | ||
| Validate extension JSON: API was removed: classes/GLTFDocumentExtensionTextureWebP |
There was a problem hiding this comment.
These two entries are new, but they are mentioned in this PR as being removed from the export, so this is correct and exactly the kind of thing that could slip through before this.
There was a problem hiding this comment.
The GitHub action still raises a warning for those but on the wrong file:
There was a problem hiding this comment.
I have hidden warnings from prior versions (as I originally intended), as it is kinda unavoidable that they happen (unless editing the expected files for old versions). (tho thinking about it there may still be some issues when changing a value in multiple versions, potentially still requiring changes to old expected files)
RedworkDE
force-pushed
the
ci-compat-multi
branch
from
4dfff3e to
b83dff7
Compare
akien-mga
approved these changes
Aug 31, 2023
|
Thanks! |
This was referenced Aug 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows running the API compat checks against multiple Godot versions without having to duplicate a bunch of entries by using a scheme were, if the basename of an expected file contains an
_it will be compared against the version indicated by the part before the_but the expected errors will be concatenated to those of the version after the underscore (possibly recursively).This changes prevents accidentally breaking APIs that there newly added in 4.1.