Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Modules] Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable #81760

Merged
merged 1 commit into from
Sep 26, 2023
Merged

[Modules] Replace ERR_FAIL_COND with ERR_FAIL_NULL where applicable #81760

merged 1 commit into from
Sep 26, 2023

Conversation

AThousandShips
Copy link
Member

@AThousandShips AThousandShips commented Sep 16, 2023 •
edited
Loading

Second to last one, the last one will be servers, can combine it with this one but it is significantly larger, but might be easier to just keep it to one final push as that one is relatively hard to individually investigate in any case.

Then we can all rest!

@AThousandShips AThousandShips added this to the 4.2 milestone Sep 16, 2023
@AThousandShips AThousandShips requested review from a team as code owners September 16, 2023 20:14
@AThousandShips
Copy link
Member Author

(testing an additional case)

@AThousandShips
Copy link
Member Author

There's also one instance in thirdparty/enet/godot.cpp which doesn't seem to be "truly" thirdparty, can add that one too for completeness, but can be merged as is regardless (won't convert to draft, but testing an case I might have missed earlier)

@AThousandShips AThousandShips requested review from a team as code owners September 26, 2023 13:30
@akien-mga
Copy link
Member

There's also one instance in thirdparty/enet/godot.cpp which doesn't seem to be "truly" thirdparty, can add that one too for completeness, but can be merged as is regardless (won't convert to draft, but testing an case I might have missed earlier)

Yeah feel free to add that one.

@AThousandShips AThousandShips requested a review from a team as a code owner September 26, 2023 13:51
@akien-mga akien-mga merged commit 7a4d55d into godotengine:master Sep 26, 2023
@akien-mga
Copy link
Member

Thanks!

@AThousandShips AThousandShips deleted the null_check_modules branch September 26, 2023 16:43
@AThousandShips
Copy link
Member Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akien-mga akien-mga akien-mga approved these changes

Assignees
No one assigned
Labels
enhancement topic:codestyle
Projects
None yet
Milestone
4.2
Development

Successfully merging this pull request may close these issues.
2 participants
@AThousandShips @akien-mga