C#: Fix typed arrays not saving properly

[Repiteo]

Fixes a typo in ScriptPropertiesGenerator.cs that was making the passed hint TypeString instead of ArrayType. While I'm not certain of the full ramifications of fixing this error, one immediate benefit is having resources correctly save arrays as typed if they're exported as such (like GDScript)

---

Example file to save a single "123" entry

public partial class Main : Node2D
{
    [Export]
    private Godot.Collections.Array<int> _array;
}

Before:

_array = [123]

After:

_array = Array[int]([123])

[raulsntos]

From what I can see GDScript also uses PROPERTY_HINT_TYPE_STRING for exported arrays:

godot/modules/gdscript/gdscript_parser.cpp

Lines 4145 to 4147 in 6916349

	variable->export_info.hint = PROPERTY_HINT_TYPE_STRING;
	variable->export_info.hint_string = hint_prefix + ":" + variable->export_info.hint_string;
	variable->export_info.type = Variant::ARRAY;

And changing the hint type would also require changing the hint_string, because I think the %s/%s:%s format is only meant to be used with PROPERTY_HINT_STRING.

I'm not entirely sure what hint and hint_string exported arrays are supposed to use, there was some previous discussion about this: #79366 (comment). But my guess is that these changes are not enough for what you are trying to fix, and the current behavior seems correct. So what issue is this trying to solve? Does it matter if the array is stored as untyped in the serialized scene? I'd assume it makes no difference.

[Repiteo]

Huh! That's certainly strange, but can't argue with the fact the live version works

Regardless of if there's a difference in serialization of a typed vs untyped array, I imagine it'd be convenient if resources saved uniformly. So if this hint string was required in the first place, then it must mean the actual serialization utilizes some other means to tell if an array is typed or not. This method takes effect for GDScript, but not CSharp

[raulsntos]

So I tested exported typed arrays in Godot v4.1.2.stable.mono.official.399c9dc39, and this is how the scene is serialized:

[gd_scene load_steps=3 format=3 uid="uid://b4e5y5y8e3b15"]

[ext_resource type="Script" path="res://MyNode.cs" id="1_ja7li"]
[ext_resource type="Script" path="res://MyNode.gd" id="2_n82wm"]

[node name="Main" type="Node"]

[node name="MyNodeCS" type="Node" parent="."]
script = ExtResource("1_ja7li")
NumberArray = Array[int]([1, 2, 3])

[node name="MyNodeGD" type="Node" parent="."]
script = ExtResource("2_n82wm")
number_array = Array[int]([1, 2, 3])

So it seems it's already using the typed array for serialization in both C# and GDScript. How did you get it to serialize using the untyped array? What version of Godot were you using?

[Repiteo]

Huh… I'm not sure what happened then. The dev build I was testing on had this bug, but that's not the case for 4.1.2 nor the recent 4.2 beta3. I'll have to do some digging to see what happened

[Repiteo]

As this doesn't seem to represent the live nor upcoming godot versions, I'll be closing this PR. If I find a consistent means of replication, I'll make a new PR with whatever new context came up