Prevent _allocate_placeholders crash if p_version->variants is null
#83780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timothyqiu
reviewed
Oct 22, 2023
jsjtxietian
force-pushed
the
prevent-null-variant-crash
branch
from
18fcdf3 to
5f85a04
Compare
clayjohn
approved these changes
Oct 23, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the cause of crash of #83742. cc @clayjohn
However the situation which triggerred that crash is the wrong use of varying, which I suppose it can be prevented by better varying checking or at least better documentation? Not sure whether I should put that in this pr too (Ater I figured out how to fix it tmr).