Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reading shadow filter quality from project settings in compatibility #83943

Closed
wants to merge 37 commits into from
Closed

Fix reading shadow filter quality from project settings in compatibility #83943

wants to merge 37 commits into from

Conversation

chybby
Copy link
Contributor

@chybby chybby commented Oct 25, 2023

Fixes #83380.

@chybby chybby requested a review from a team as a code owner October 25, 2023 13:56
@AThousandShips AThousandShips added this to the 4.2 milestone Oct 25, 2023
@akien-mga
Copy link
Member

For Clay when reviewing: might be worth double checking in RendererSceneRenderRD::init() whether there's any other setting supported in the GL Compat renderer that's not properly initialized.

timothyqiu and others added 17 commits October 25, 2023 22:51
@timothyqiu
Translate TextEdit placeholder
d53529f
@AThousandShips
Ensure input event is valid in PopupMenu::activate_item_by_event
f721b34
@SilicDev
fix assignment to vec2 tests
c0808d5
@bruvzg
[Menu Bar] Update min. size when items are added/removed/changed.
961e8af
@SaracenOne
Fix crash when reimporting with Skeleton3D selected.
ed083a9
@kitbdev
Fix TabContainer drag to rearrange
b788487
@Setadokalo
Fix freeze when requesting clipboard image from our own window
1d9ec3c
@akien-mga
Merge pull request godotengine#81510 from garychia/unedit_created_script
9f20a4a 
SceneTreeDock: Avoid changing the currently edited object when attaching a script
@akien-mga
Merge pull request godotengine#82415 from Calinou/reflectionprobe-fix…
79e9e20 
…-high-max-distance-rendering-2

Clamp ReflectionProbe Max Distance to 262,144 to fix rendering issues
@akien-mga
Merge pull request godotengine#83881 from jsjtxietian/fix-generated-p…
8835db5 
…article-shader-use-noise-direction-before-define

Fix `noise_direction` variable used before initialized in particle shader when using turbulence with collisions
@akien-mga
Merge pull request godotengine#83925 from jsjtxietian/fix-timer-error…
e566167 
…-when-base-button-leave-tree-and-feedback

Fix BaseButton `shortcut_feedback`'s timer will raise error when the button is removed from the scene tree
@akien-mga
Merge pull request godotengine#83930 from underdoeg/feature-support-e…
1b3e00d 
…gl-1-4

Add support for EGL 1.4
@akien-mga
Merge pull request godotengine#83937 from Jordyfel/potential-crash-on…
27679db 
…-move

Fix potential crash on failed move
@akien-mga
Merge pull request godotengine#83946 from timothyqiu/text-edit-placeh…
70f50c9 
…older

Translate TextEdit placeholder
@akien-mga
Merge pull request godotengine#83952 from AThousandShips/popup_crash
cb167fd 
Ensure input event is valid in `PopupMenu::activate_item_by_event`
@akien-mga
Merge pull request godotengine#83961 from bruvzg/menu_bar_update_size
d298200 
[Menu Bar] Update min. size when items are added/removed/changed.
@akien-mga
Merge pull request godotengine#83964 from SaracenOne/skeleton_reimpor…
53a894e 
…t_crashfix

Fix crash when reimporting with Skeleton3D selected.
jsjtxietian and others added 10 commits October 26, 2023 17:13
@jsjtxietian
Fix FastNoiseLite.get_seamless_image function will crashes with bad p…
1fafca5 
…aram
@bruvzg
Fix macOS and Windows build with statically linked ANGLE/EGL.
2d0cd5f
@SaracenOne
Add method check for _notify_skeleton_bones_renamed.
d0e5bff
@akien-mga
Merge pull request godotengine#83491 from jsjtxietian/pass-screen-siz…
815b24d 
…e-when-render-shadow

Pass viewport size to shadow pass instead of using Vector2i(1,1)
@akien-mga
Merge pull request godotengine#83959 from SilicDev/variant-assignment…
8d3820d 
…-test-fix

Fix Variant assignment to Vec2 tests
@akien-mga
Merge pull request godotengine#83978 from jsjtxietian/fix-FastNoiseLi…
7443fb2 
…te.get_seamless_image-crash-on-bad-input

Fix `FastNoiseLite.get_seamless_image` function crash with bad param
@akien-mga
Merge pull request godotengine#83986 from SaracenOne/skeleton_bones_r…
346459e 
…enamed_check

Add method check for `_notify_skeleton_bones_renamed`.
@akien-mga
Merge pull request godotengine#83988 from bruvzg/egl_static
46cb7f9 
Fix macOS and Windows build with statically linked ANGLE/EGL.
@chybby
Fix reading shadow filter quality from project settings in compatibility
26f6817 
Fixes godotengine#83380.
@chybby
Merge branch 'master' of https://github.com/chybby/godot
e10d291
@chybby chybby requested review from a team as code owners October 26, 2023 12:08
@chybby chybby mentioned this pull request Oct 26, 2023
Merged
@AThousandShips
Copy link
Member

Superseded by:

@AThousandShips AThousandShips removed this from the 4.2 milestone Oct 26, 2023
@AThousandShips AThousandShips removed request for a team October 26, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
archived bug topic:rendering topic:3d
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compatibility Renderer Soft Shadows at locked at PCF5 at runtime