Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose get_global_name() method to the editor #85115

Closed
wants to merge 1 commit into from

Conversation

fkeyzuwu
Copy link
Contributor

Thought this would be useful, as currently there isn't an easy way to get the global class name of a a given script.

@fkeyzuwu fkeyzuwu requested review from a team as code owners November 20, 2023 01:41
@fkeyzuwu fkeyzuwu changed the title Exposed get_global_name() method to the editor Expose get_global_name() method to the editor Nov 20, 2023
@AThousandShips AThousandShips added this to the 4.x milestone Nov 20, 2023
@Calinou
Copy link
Member

Calinou commented Nov 20, 2023

@fkeyzuwu fkeyzuwu force-pushed the expose-get-global-name branch 2 times, most recently from c087e4f to 3e6bff5 Compare November 21, 2023 01:15
@fkeyzuwu
Copy link
Contributor Author

fkeyzuwu commented Nov 21, 2023

Fixed the accidental documentation inconsistency with the API from the method returning a StringName and not a Script, should pass the test now. Next I squashed the two commits into one. Sorry for the messy git history, first time using these commands 😬

@fkeyzuwu fkeyzuwu force-pushed the expose-get-global-name branch from 3e6bff5 to e6d5e9c Compare November 21, 2023 01:26
@fkeyzuwu
Copy link
Contributor Author

Closing since I just found its a duplicate of #80487.

@fkeyzuwu fkeyzuwu closed this Nov 21, 2023
@YuriSizov YuriSizov removed this from the 4.x milestone Nov 21, 2023
@fkeyzuwu fkeyzuwu deleted the expose-get-global-name branch November 23, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants