Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow splitting GodotDisabledSourceGenerators by comma (Updates ExtensionMethods.cs) #88682

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
+2 −1
Open

Allow splitting GodotDisabledSourceGenerators by comma (Updates ExtensionMethods.cs) #88682

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e743f2
Update ExtensionMethods.cs
InfiniteCactusDev Feb 22, 2024
5c5e965
add a comment
InfiniteCactusDev Feb 22, 2024
cab78f3
Typo
InfiniteCactusDev Mar 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/mono/editor/Godot.NET.Sdk/Godot.SourceGenerators/ExtensionMethods.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,11 +26,12 @@ public static bool IsGodotToolsProject(this GeneratorExecutionContext context)
toggle != null &&
toggle.Equals("true", StringComparison.OrdinalIgnoreCase);

// NOTE: Settings in the editorconfig file (including csproj files) should not use ; as a separator as it will be treated as a comment
public static bool IsGodotSourceGeneratorDisabled(this GeneratorExecutionContext context, string generatorName) =>
AreGodotSourceGeneratorsDisabled(context) ||
(context.TryGetGlobalAnalyzerProperty("GodotDisabledSourceGenerators", out string? disabledGenerators) &&
disabledGenerators != null &&
disabledGenerators.Split(';').Contains(generatorName));
disabledGenerators.Split(';', ',').Contains(generatorName));

public static bool InheritsFrom(this ITypeSymbol? symbol, string assemblyName, string typeFullName)
{
Expand Down
Loading