Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename "Add Node Here to Add 2D Node Here to avoid confusion when right click on 2d scene to add nodes #91970

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jsjtxietian
Copy link
Contributor

@jsjtxietian jsjtxietian marked this pull request as ready for review May 15, 2024 04:07
@AThousandShips AThousandShips added this to the 4.x milestone May 15, 2024
@timothyqiu
Copy link
Member

timothyqiu commented May 15, 2024

This makes things clearer technically. But I don't think users who would try to instantiate AnimationPlayer in a 2D editor would understand what a Canvas Node is.

I would suggest changing it to simply "Add Node", not restricting to CanvasItem only, and move the newly created node if it's 2D / Control.

@KoBeWi
Copy link
Member

KoBeWi commented May 26, 2024

That option originally allowed adding any node, but was changed on request: #41437 (comment)
If it's confusing, maybe it can say "Add 2D Node Here".

when right click on 2d scene to add nodes
Copy link
Contributor

@Mickeon Mickeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my opinion it we really want to mention "canvas nodes" it should be the full name of the class ("Add CanvasNode Here...") to keep it untranslated.

But "Add 2D Node Here..." is completely fine and more accessible.

@Mickeon Mickeon changed the title Rename "Add Node Here to Add a Canvas Node Here to avoid confusion when right click on 2d scene to add nodes Rename "Add Node Here to Add 2D Node Here to avoid confusion when right click on 2d scene to add nodes Jun 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants