-
-
Notifications
You must be signed in to change notification settings - Fork 21.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix engine crashing when using Down Arrow selection on Tree with no selection #93179
Conversation
When nothing is selected, you can't use arrows or any other button to select something. Which means that you can't select any item when you are Tabbing into the tree, making it less friendly for keyboard controls. #92959 seems like a better approach, but it still has the problem I mentioned in my comment. Code of both PRs looks fine though. |
Amended commit to be more like #92959 Seemed to fix the issues @Hilderin raised. In general, this PR seems to work well. |
|
Thanks for the repo steps! The problem was |
Thanks! |
Fixes #92958
Now when Down (or Up) key is used to change selection on a
Tree
withSELECT_MULTI
enabled, the code will check whether anything is selected before trying to change the selection. Previously it would not perform this check and a crash would be possible if nothing was selected.This has a different approach from #92959, though aiming to solve the same bug.