RichTextLabel: Fix missing function bindings for internal real-time fx #93412
+49
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Should help users who want to use GDScript in conjunction with internal real time effects such as Tornado, Rainbow and Shake. Fixes godotengine#77120
bruvzg
reviewed
Jun 21, 2024
There was a problem hiding this comment.
Seems fine, but docs probably should include info about function parameters (can be mostly copy-pasted from https://docs.godotengine.org/en/latest/tutorials/ui/bbcode_in_richtextlabel.html).
| <param index="0" name="start_index" type="int" /> | ||
| <param index="1" name="length" type="int" /> | ||
| <description> | ||
| Adds a [code skip-lint][fade][/code] tag to the tag stack. |
There was a problem hiding this comment.
Suggested change
| Adds a [code skip-lint][fade][/code] tag to the tag stack. | |
| Adds a [code skip-lint][fade][/code] tag to the tag stack. |
Space at the end.
akien-mga
reviewed
Jun 21, 2024
Comment on lines
+5923
to
+5927
| ClassDB::bind_method(D_METHOD("push_fade", "start_index", "length"), &RichTextLabel::push_fade); | ||
| ClassDB::bind_method(D_METHOD("push_shake", "strength", "rate", "connected"), &RichTextLabel::push_shake); | ||
| ClassDB::bind_method(D_METHOD("push_wave", "frequency", "amplitude", "connected"), &RichTextLabel::push_wave); | ||
| ClassDB::bind_method(D_METHOD("push_tornado", "frequency", "radius", "connected"), &RichTextLabel::push_tornado); | ||
| ClassDB::bind_method(D_METHOD("push_pulse", "color", "frequency", "ease"), &RichTextLabel::push_pulse); |
There was a problem hiding this comment.
Nitpick, but conceptually the lines before and after around about cells. I would move these push_ methods just after push_customfx which is the generic one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should help users who want to use GDScript in conjunction with internal real time effects
wave,tornado,rainbow,fade,pulseandshake. Tested using a simple GDScript scene and seems to work without issue.Fixes #77120