Add unit tests for Decal
#93463
Open
Add unit tests for Decal
#93463
+136
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Well, it seems I do not know how to use the clang formatter from Visual Studio. I am sorry. |
tests/scene/test_decal.h
Outdated
|
|
||
| #ifndef TEST_DECAL_H | ||
| #define TEST_DECAL_H | ||
| #include "scene/main/scene_tree.h" |
There was a problem hiding this comment.
Suggested change
| #include "scene/main/scene_tree.h" |
Don't need to include this
There was a problem hiding this comment.
Can I somehow test my code before opening the pull request?
There was a problem hiding this comment.
By building it and running with --test, or enabling CI on your own fork
99 tasks
Geometror
reviewed
Jul 12, 2024
AThousandShips
previously requested changes
Jul 12, 2024
Co-authored-by: A Thousand Ships <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of the issue: #43440
As stated in the description, I called various setter and getters, then checking whether the function get_aabb() returns the expected result.