Add unit tests for StyleBoxTexture
#95218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
99 tasks
Calinou
reviewed
Aug 6, 2024
Calinou
reviewed
Aug 6, 2024
Calinou
approved these changes
Aug 6, 2024
AThousandShips
changed the title
StyleBoxTexture
Capitalization fix in test_style_box_texture.h Co-authored-by: Hugo Locurcio <[email protected]> Newline fix in test_style_box_texture.h Co-authored-by: Hugo Locurcio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to Issue #43440
These unit tests verify the constructor, getters, and setters of the StyleBoxTexture class.
As a note, I excluded StyleBoxTexture::get_style_margin() because its current implementation causes a build error due to accessing a protected member of StyleBoxTexture, namely StyleBoxTexture::texture_margin. The method doesn't seem to be used anywhere, but this may be worth looking into as a separate Issue. Also, I excluded StyleBoxTexture::draw() because it interacts with another component of the engine, which seemed out-of-scope.
This is my first PR, so please let me know if there is anything I should fix or add, and I will follow-up.