Add unit tests for PhysicsMaterial #97227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
previously requested changes
Sep 20, 2024
AThousandShips
changed the title
|
Thank you for your contribution! These tests look good to me, but can't say if they cover things that we want to test for or not so this will have to be looked over by the physics team to give their approval If you have any questions, or just want to join the developer community channels, feel free to join the developer chat! |
Calinou
reviewed
Oct 1, 2024
Calinou
reviewed
Oct 1, 2024
Calinou
reviewed
Oct 1, 2024
Calinou
reviewed
Oct 1, 2024
Calinou
reviewed
Oct 1, 2024
Calinou
reviewed
Oct 1, 2024
rburing
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Looks good to me, as it tests all that can be tested in isolation (using only this class). Please squash the commits as required by our workflow (and ideally, change the commit message to the current title of this PR).
|
Done! |
|
Thanks! And congrats for your first merged Godot contribution 🎉 |
99 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unit tests for PhysicsMaterial for tracker #43440
I am somewhat unsure about the relevancy of theses tests but here they are. Mostly testing setters and getters.