Add GraphEdit.cut_nodes_request signal
#97229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AThousandShips
changed the title
GraphEdit.cut_nodes_request signal
akien-mga
reviewed
Sep 20, 2024
|
Makes sense to me from a quick review, but I'll let GraphEdit / VisualShader editor experts (@Geometror or @Chaosus) evaluate further. |
Geometror
reviewed
Sep 23, 2024
There was a problem hiding this comment.
Looking good; tested and works as expected!
Last thing remaining: Please squash your commits into one as per https://docs.godotengine.org/en/stable/contributing/workflow/pr_workflow.html
aryan-11825114
force-pushed
the
ctrl-x-visual-shader
branch
from
2e3ca0a to
9c21c3f
Compare
|
Please adjust the commit message to be more specific: "Add cut_nodes_request signal to GraphEdit" |
aryan-11825114
force-pushed
the
ctrl-x-visual-shader
branch
from
9c21c3f to
b4460c6
Compare
Geometror
approved these changes
Sep 27, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97064
Should also close #92776